Skip to content

AXON-1642 - Change to ensure compatibility across OS's & Shells #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwieger-atlassian-com wants to merge 7 commits into
base: main
Choose a base branch
from
Open

AXON-1642 - Change to ensure compatibility across OS's & Shells #1290

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aa341f3
Change to ensure compatibility across OS's
bwieger-atlassian-com Nov 14, 2025
9dc70c6
Remove the chmod stuff. Not reported by a customer, not a top error
bwieger-atlassian-com Nov 14, 2025
b6e053f
CHANGELOG
bwieger-atlassian-com Nov 14, 2025
fc22b28
Merge branch 'main' into gh-1289
bwieger-atlassian-com Dec 2, 2025
74e83c8
Merge branch 'main' into gh-1289
bwieger-atlassian-com Dec 3, 2025
a43a9d1
Merge branch 'main' into gh-1289
bwieger-atlassian-com Dec 5, 2025
7d5d5e6
clean up changelog
bwieger-atlassian-com Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/rovo-dev/rovoDevProcessManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,23 @@ class RovoDevTerminalInstance extends Disposable {
return new Promise<void>((resolve, reject) => {
access(this.rovoDevBinPath, constants.X_OK, async (err) => {
if (err) {
reject(new Error(`executable not found.`));
if (err.code === 'ENOENT') {
reject(
new Error(
`Executable not found at: ${this.rovoDevBinPath}. Error: ${err.message} (${err.code})`,
),
);
} else if (err.code === 'EACCES') {
reject(
new Error(
`Executable found but not executable. Please check permissions: ${this.rovoDevBinPath}. Error: ${err.message} (${err.code})`,
),
);
} else {
reject(
new Error(`Cannot access executable: ${err.message}${err.code ? ` (${err.code})` : ''}`),
Copy link
Contributor

@atlassian atlassian bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎 Code Readability

Add a space before the opening parenthesis for consistency: ${err.message}${err.code ? (${err.code}) : ''} should be ${err.message}${err.code ? (${err.code}) : ''}.

);
}
return;
}

Expand Down Expand Up @@ -521,6 +537,7 @@ class RovoDevTerminalInstance extends Disposable {
isTransient: true,
iconPath: this.rovoDevIconUri,
env: {
...process.env,
USER: process.env.USER || process.env.USERNAME,
USER_EMAIL: credentials.authInfo.username,
ROVODEV_SANDBOX_ID: this.extensionApi.metadata.appInstanceId(),
Expand Down
Loading