Skip to content

Fix invalid SQL generation with empty where groups #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulianVennen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix invalid SQL generation with empty where groups #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Query/Query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public function where(WhereCondition|array|WhereGroup $where): static
*/
public function getWhere(): WhereGroup|null
{
if ($this->where) {
if ($this->where && $this->where->count() > 0) {
return $this->where;
}

Expand Down Expand Up @@ -192,4 +192,4 @@ public function getLimit(): ?Limit
{
return $this->limit;
}
}
}
10 changes: 10 additions & 0 deletions test/tests/SQLTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,16 @@ public function testSelect()
$this->assertEquals("SELECT * FROM `test`", $this->sql->generate($query));
}

public function testSelectEmptyWhere()
{
$query = new SelectQuery(
new WhereGroup(),
);
$query->modelClassName = TestModel::class;

$this->assertEquals("SELECT * FROM `test`", $this->sql->generate($query));
}

public function testSelectWhereCondition()
{
$query = new SelectQuery(
Expand Down
Loading