Conversation
accidential match because we add a null value to the Jacket list in certain cases.
Variable to prevent mistakes. The Check "If jacket is a single context and selector list, encapsulate." was only done in the Mixin but not in the Function.
To add a context to an existing Jacket Variable was not easy to not destroy the consistency of the list. Therefor I created this function.
It will return $value if the $contexts match or $else if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the discussed function
jacket-else()to the code base and added the documentation.Going through the code I found some places where I thought I should change something else.
The most unsure change was done in my first commit where I removed unnecessary code. It was not documented and seamed to me as a leftover from a former concept.
I hope those changes do not interfere with your ideas for your project and would be glad to see them accepted.
If you need some Changes that I Should still do, please let me know.
Regards, Hannes