fix: override vulnerable jsonpath-plus in multi-parser dependencies#1145
Open
armorbreak001 wants to merge 3 commits intoasyncapi:masterfrom
Open
fix: override vulnerable jsonpath-plus in multi-parser dependencies#1145armorbreak001 wants to merge 3 commits intoasyncapi:masterfrom
armorbreak001 wants to merge 3 commits intoasyncapi:masterfrom
Conversation
The ajv-formats uri-reference format validator incorrectly rejects valid URI references containing square brackets ([, ]), which are legal per RFC 3986 and RFC 6901. This caused false validation failures for $refs pointing to components whose keys contain special characters (e.g. JMS message names like "test:[HandleFirst,HandleSecond]"). Fixes asyncapi#1132
Custom schema parsers were not being triggered for message payloads defined through an operation's channel reference (operations.*.channel.messages.*). This path was missing from customSchemasPathsV3. Fixes asyncapi#1099
The parserapiv1 (parser@^2.1.0) and parserapiv2 (parser@3.0.0-next-major-spec.8) aliases depend on jsonpath-plus@^7.2.0 which has known vulnerabilities. Add npm overrides to force jsonpath-plus>=10.0.7 across all nested deps. Fixes asyncapi#1065
armorbreak001
requested review from
asyncapi-bot-eve,
fmvilas and
magicmatatjahu
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1065
Problem
@asyncapi/multi-parserdepends on older versions of@asyncapi/parservia npm alias packages:parserapiv1→npm:@asyncapi/parser@^2.1.0(resolves to 2.1.x, usesjsonpath-plus@^7.2.0)parserapiv2→npm:@asyncapi/parser@3.0.0-next-major-spec.8(usesjsonpath-plus@^7.2.0)Both of these old parser versions depend on
jsonpath-plus@7.2.0which has known security vulnerabilities (CVEs in versions < 10.0.7).Fix
Added npm
overridesinpackages/multi-parser/package.jsonto forcejsonpath-plus>=10.0.7across all nested dependencies, including the aliased parser packages.This approach:
How to verify