fix: add timeout handling to registryValidation to prevent CLI hang#2096
Open
TeapoyY wants to merge 1 commit intoasyncapi:masterfrom
Open
fix: add timeout handling to registryValidation to prevent CLI hang#2096TeapoyY wants to merge 1 commit intoasyncapi:masterfrom
TeapoyY wants to merge 1 commit intoasyncapi:masterfrom
Conversation
When --registry-url points to an unreachable host, the CLI would hang indefinitely due to fetch() having no timeout. This fix: - Adds AbortController with a 5-second timeout - Uses clearTimeout to avoid memory leaks on successful fetch - Provides a clear error message when timeout occurs - Properly propagates the original error when fetch fails for other reasons Fixes asyncapi#2027
TeapoyY
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
2 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --registry-url points to an unreachable host, the CLI would hang indefinitely due to fetch() having no timeout.
Changes
Testing
Tested manually with unreachable registry URL (blackholed IP):
\
asyncapi generate fromTemplate asyncapi.yaml @asyncapi/html-template --registry-url http://10.255.255.1
\
Expected: CLI fails fast with timeout error message
Before: CLI hangs indefinitely
Fixes #2027