ENH: Change tapregext code to handle proposed use of forMode to allow specifying limits per mode#757
Draft
stvoutsin wants to merge 1 commit into
Draft
ENH: Change tapregext code to handle proposed use of forMode to allow specifying limits per mode#757stvoutsin wants to merge 1 commit into
stvoutsin wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 79.79% 79.93% +0.13%
==========================================
Files 91 91
Lines 10297 10424 +127
==========================================
+ Hits 8217 8332 +115
- Misses 2080 2092 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ifying limits per mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is my attempt to provide client support for the proposal to add a
forModeattribute to capabilities to allow specifying mode-specific (syncvsasync) limits (executionDuration,retentionPeriod,outputLimit, anduploadLimit) as written in ivoa-std/TAPRegExt#10.The current behaviour is that PyvVO will warn if more than 1 of these elements appears, which makes sense for the existing TAPRegExt spec.
Since this is still a PR in
TAPRegExtI'll leave this as a Draft PR mainly for visibility and discussion. If we don't want this cluttering the PR list I could also move this into an issue and add a comment to refer to the branch with the changes.Changes
Limit elements (
executionDuration,outputLimitetc.) are now parsed into lists with newget_x(mode)methods for mode-aware getters.One place I noticed that can take advantage of these mode-specific limits is the
run_asynctimeout, so I've changed that to default to the service's advertised async execution duration as its wait timeout.Compatibility
With the approach I've gone with existing code that depends on the singular limit properties (maxrec, and hardlimit) should be fine.