Deep copy bug in ElementWithXSIType#756
Draft
andamian wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 79.79% 79.84% +0.04%
==========================================
Files 91 91
Lines 10297 10299 +2
==========================================
+ Hits 8217 8223 +6
+ Misses 2080 2076 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
reviewed
May 26, 2026
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Could you please add a chaneglog entry? I don't think I'll do another bugfix, next release will be 1.9 sometimes next week.
I also wonder if we could do a reasonable test that trips without this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #755