Draft
Conversation
indygreg
force-pushed
the
gps-stdlib-tests
branch
20 times, most recently
from
305d967 to
9d84cd3
Compare
Default runners have 2 CPUs. We can achieve a nice speed-up (but not quite linear) by leveraging runners with more CPUs.
Way back when we only supported statically linked extension modules. And we had to disable `_testcapi` because it wouldn't build statically. Now that we support building extension modules as shared libraries, it makes sense for extension modules in support of tests to not be part of libpython and to be shared libraries. This commit makes that change. And since `_testcapi` is buildable as a shared library, we enable it. In doing so, we eliminate the largest single source of test failures.
indygreg
force-pushed
the
gps-stdlib-tests
branch
6 times, most recently
from
165be3a to
85916a9
Compare
This removes the dependency on openssl / pkg-config. This in turn avoids ~30s of overhead on the crate build CI job to install these dependencies. While I was here I ran `cargo update` to pull in newer versions of various dependencies. I also removed some unused dependencies from `Cargo.toml`.
indygreg
force-pushed
the
gps-stdlib-tests
branch
from
85916a9 to
07e58af
Compare
indygreg
force-pushed
the
gps-stdlib-tests
branch
5 times, most recently
from
19f3936 to
53fa0c4
Compare
indygreg
force-pushed
the
gps-stdlib-tests
branch
from
53fa0c4 to
8e9d164
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a draft. Assessing how much effort it is to run the stdlib test suite in CI.