Skip to content

Fix CLDDP test regularization initial value #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astomodynamics merged 1 commit into from
Nov 12, 2025
Merged

Fix CLDDP test regularization initial value #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/cddp_core/test_clddp_solver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ TEST(CLDDPTest, SolveCar)
options.num_threads = 1;
options.verbose = true;
options.debug = false;
options.regularization.initial_value = 1e-7;
options.regularization.initial_value = 1e-6;
Copy link

@gemini-code-assist gemini-code-assist bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line sets the regularization initial value to 1e-6, which is its default value. I noticed that several other options in this test are also explicitly set to their default values (e.g., acceptable_tolerance, verbose, debug). To improve code clarity and reduce redundancy, consider removing the explicit assignments for all options that use their default values. This would make the test setup cleaner by only highlighting the non-default parameters.

options.return_iteration_info = true; // Get detailed iteration history

// Set options
Expand Down