Replaced SIPp -mp with -min_rtp_port#25
Conversation
| self.test_dir, default_args[defarg])) | ||
|
|
||
| if '-mp' not in default_args: | ||
| if '-min_rtp_port' not in default_args: |
There was a problem hiding this comment.
This is not backwards compatible. Personally the SIPp I use isn't new enough to have this, so it would no longer work for me. I'm on Ubuntu 22.04, so I expect others would experience the same. Is the version shipping in distributions or has to be built manually? Is it possible to make this backwards compatible to support both based on detection of the version?
|
A little sipp history... In 3.5.2, all 3 options ( So now to answer @jcolp's question... Fedora 40 actually ships sipp-3.7.2 but as far as I can tell, no other distro does and altrough I do use Fedora 40, I build and use the same sipp version that the testsuite contrib/scripts/install_prereq script istalls...v3.6.1. That's the version anyone who runs the testsuite should use if they want repeatable results. So @maurice2k you'd need to do a few things if you want to make this compatible with various versions but I'm not sure it's worth the trouble. If we do upgrade the sipp version the testsuite uses, we'd wait for v3.7.3 to get the
|
SIPp parameter -mp has been replaced with -min_rtp_port in SIPp v3.7.0 (released April 2023).