tests/channels/pjsip/message: Add out-of-dialog Contact stripping test#124
Open
AlexisHadj wants to merge 1 commit intoasterisk:masterfrom
Open
tests/channels/pjsip/message: Add out-of-dialog Contact stripping test#124AlexisHadj wants to merge 1 commit intoasterisk:masterfrom
AlexisHadj wants to merge 1 commit intoasterisk:masterfrom
Conversation
This new test verifies that Asterisk correctly strips the Contact header from outbound MESSAGE requests, as required by RFC 3428. 1-Added SIPp scenarios to send and receive MESSAGEs with inverse validation on the Contact header. 2-Added Asterisk configuration (pjsip.conf, extensions.conf) to support the test. 3-Registered the new test in the pjsip message test suite.
Author
|
Note: This test is associated with the change in Pull Request #1729 therefore should be merged after Pull Request #1729 . That is the reason master-gates check fails with ".....Regexp matched but should not...."" |
There was a problem hiding this comment.
Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.
- The PR title does not match the commit title. This can cause confusion for reviewers and future maintainers. GitHub doesn't automatically update the PR title when you update the commit message so if you've updated the commit with a force-push, please update the PR title to match the new commit message body.
- The PR description does not match the commit message body. This can cause confusion for reviewers and future maintainers. GitHub doesn't automatically update the PR description when you update the commit message so if you've updated the commit with a force-push, please update the PR description to match the new commit message body.
- The are no
cherry-pick-toheaders in any comment in this PR. If the PR applies to more than just the branch it was submitted against, please add a comment with one or morecherry-pick-to: <branch>headers or a comment withcherry-pick-to: noneto indicate that this PR shouldn't be cherry-picked to any other branch. See the Code Contribution documentation for more information.
Documentation:
|
Workflow PRCheck failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new test verifies that Asterisk correctly strips the Contact header from outbound MESSAGE requests, as required by RFC 3428.
1-Added SIPp scenarios to send and receive MESSAGEs with inverse
validation on the Contact header.
2-Added Asterisk configuration (pjsip.conf, extensions.conf) to
support the test.
3-Registered the new test in the pjsip message test suite.
Note: This test is associated with the change in Pull Request #1729