Skip to content

fix: Add macOS (Darwin) compatibility for building Asterisk#1758

Merged
github-actions[bot] merged 1 commit intoasterisk:masterfrom
iamprashant:master
Feb 26, 2026
Merged

fix: Add macOS (Darwin) compatibility for building Asterisk#1758
github-actions[bot] merged 1 commit intoasterisk:masterfrom
iamprashant:master

Conversation

@iamprashant
Copy link
Copy Markdown
Contributor

  • Makefile: Skip /usr/lib/bundle1.o on modern macOS (doesn't exist)
  • Makefile.rules: Skip -fno-partial-inlining for clang (gcc-only flag)
  • include/asterisk/utils.h: Use asterisk/endian.h instead of <endian.h>
  • main/Makefile: Add Darwin-specific pjproject linking with -force_load
  • main/strcompat.c: Include poll-compat.h, use ast_poll()
  • main/xml.c: Add ASTMM_LIBC ASTMM_IGNORE for libxml2 compatibility
  • res/res_pjsip/config_transport.c: Define TCP keepalive constants for macOS

Tested on macOS Darwin 25.2.0 (Apple Silicon ARM64)

- Makefile: Skip /usr/lib/bundle1.o on modern macOS (doesn't exist)
- Makefile.rules: Skip -fno-partial-inlining for clang (gcc-only flag)
- include/asterisk/utils.h: Use asterisk/endian.h instead of <endian.h>
- main/Makefile: Add Darwin-specific pjproject linking with -force_load
- main/strcompat.c: Include poll-compat.h, use ast_poll()
- main/xml.c: Add ASTMM_LIBC ASTMM_IGNORE for libxml2 compatibility
- res/res_pjsip/config_transport.c: Define TCP keepalive constants for macOS

Tested on macOS Darwin 25.2.0 (Apple Silicon ARM64)
@sangoma-oss-cla
Copy link
Copy Markdown

sangoma-oss-cla Bot commented Feb 5, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Checklist Complete

@github-actions github-actions Bot added the has-pr-checklist A PR Checklist is present on the PR label Feb 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

Workflow PRCheck completed successfully

@iamprashant
Copy link
Copy Markdown
Contributor Author

iamprashant commented Feb 24, 2026

cherry-pick-to: 20
cherry-pick-to: 22
cherry-pick-to: 23

@github-actions github-actions Bot dismissed their stale review February 25, 2026 02:17

Pull Request Checklist Complete

@github-actions github-actions Bot removed has-pr-checklist A PR Checklist is present on the PR has-pr-checklist-reminder labels Feb 25, 2026
@gtjoseph
Copy link
Copy Markdown
Member

@iamprashant Is there a reason you don't want this cherry-picked to the other active branches?

@gtjoseph gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label Feb 26, 2026
@github-actions github-actions Bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-test Trigger dry run of cherry-picks cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Feb 26, 2026
@github-actions
Copy link
Copy Markdown

Workflow PRCPCheck failed
20-build-no-dev-mode: cherryPick.sh: No commits for PR 1758
20-build: cherryPick.sh: No commits for PR 1758
23-build-no-dev-mode: cherryPick.sh: No commits for PR 1758

@github-actions github-actions Bot added the cherry-pick-checks-passed Cherry-Pick checks passed label Feb 26, 2026
@github-actions
Copy link
Copy Markdown

Workflow PRCPCheck completed successfully

@github-actions github-actions Bot merged commit 3e30965 into asterisk:master Feb 26, 2026
115 of 118 checks passed
@github-actions
Copy link
Copy Markdown

Successfully merged to branch master and cherry-picked to ["20","22","23"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants