Features/reimplementing the apis as modules #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored all codebases to use discard assignment (_ =) for method calls with ignored return values, improving code clarity and eliminating IDE0058 warnings. Added new NuGet package project AStar.Dev.Minimal.Api.Extensions, providing extension methods (e.g., AddBasicProduces) for consistent minimal API response documentation. Updated all minimal API endpoint registrations to use the new extension methods and discard assignment. Updated all .csproj files for NuGet packages to standardize metadata and XML doc generation. Updated solution and project references to include the new package and ensure correct dependencies. Replaced synchronous app.Run() and Log.CloseAndFlush() with their async counterparts throughout. Standardized discard assignment usage across all API, migration, configuration, seeding, and test code for consistency and to avoid IDE warnings.
jbarden
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just fixes to compiling code and updates to csproj for NuGet packages