fix: use implementing type name for Rust trait impl methods

[github-actions]

Caution

Security scanning requires review for Repo Assist

Details

The threat detection results could not be parsed. The workflow output should be reviewed before merging.

Review the workflow run logs for details.

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

When a method is defined in impl Trait for Type, the Rust analyzer was using the trait name as the qualifier instead of the implementing type. For example:

impl fmt::Display for Point {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { ... }
}

Before: CodeLens showed Display::fmt
After: CodeLens shows Point::fmt ✅

Root Cause

getFunctionName() used Array.find() on the impl_item's children to find the first type_identifier. For impl Trait for Type, the trait name comes first, so it was returned instead of the implementing type.

Fix

For impl_item nodes containing a for keyword, search for the type identifier after for. For inherent impl Type blocks, the existing behavior is unchanged.

Tests

Added 4 new unit tests covering:

• impl Trait for Type → ImplementingType::method
• impl Type → Type::method (unchanged)
• multiple trait/inherent impl methods in same file

Test Status: compile ✅ lint ✅ 103/103 unit tests passing (up from 100)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@79c99dfd73f3b7ad8ab2b0f4944838018dbe4736

[Copilot]

Pull request overview

This PR fixes Rust method qualification for trait implementations so that methods defined in impl Trait for Type are labeled with the implementing type (e.g., Point::fmt) rather than the trait name (e.g., Display::fmt), improving the CodeLens/function naming produced by the Rust metrics analyzer.

Changes:

• Update Rust function naming logic to prefer the type identifier that appears after the for keyword in impl Trait for Type blocks.
• Add unit/integration tests to cover trait impl qualification, inherent impl qualification (unchanged), and mixed impl scenarios.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/metricsAnalyzer/languages/rustAnalyzer.ts	Adjusts getFunctionName() to select the implementing type (after for) for trait impl methods.
src/unit/unit.test.ts	Adds unit tests validating correct naming for trait impls, inherent impls, and mixed impl ordering/complexity.
src/test/metricsAnalyzer/languages/rustAnalyzer.test.ts	Adds Rust analyzer test covering the impl Trait for Type naming behavior.