fix: flatten nested calculation/aggregate maps before wrapping in subquery for aggregates #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query for aggregates
When keyset pagination is combined with a relationship sort and loaded
aggregates, the query's select contains nested maps like
`%{calculations: %{__calc__0: expr}}`. Ecto doesn't allow nested maps
in subquery selects, causing an error.
This fix reuses `AshSql.Query.rewrite_nested_selects/1` (already used in
`distinct.ex` and `query.ex` for the same purpose) to flatten these
nested maps before creating the subquery in `wrap_in_subquery_for_aggregates`.
Fixes the failing test in ash-project/ash_postgres#677
7 tasks
Contributor
Author
|
(the dialyzer issue was pre-existing, not caused by changes in this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keyset pagination is combined with a relationship sort and loaded aggregates, the query's select contains nested maps like
%{calculations: %{__calc__0: expr}}. Ecto doesn't allow nested maps in subquery selects, causing an error.This fix reuses
AshSql.Query.rewrite_nested_selects/1(already used indistinct.exandquery.exfor the same purpose) to flatten these nested maps before creating the subquery inwrap_in_subquery_for_aggregates.This PR fixes the failing test added in ash-project/ash_postgres#677
Contributor checklist
Leave anything that you believe does not apply unchecked.