Skip to content

Conversation

@brionmario
Copy link
Member

@brionmario brionmario commented Jan 10, 2026

Purpose

This pull request simplifies the implementation of the getDecodedIdToken and getAccessToken methods in the AsgardeoReactClient class by removing unnecessary loading state management. This makes the code cleaner and more efficient.

Refactoring and simplification:

  • Removed the use of the withLoading wrapper from the getDecodedIdToken method in AsgardeoReactClient, allowing direct calls to asgardeo.getDecodedIdToken.
  • Removed the use of the withLoading wrapper from the getAccessToken method in AsgardeoReactClient, allowing direct calls to asgardeo.getAccessToken.

Documentation:

  • Updated the changeset to note the removal of unnecessary loading state management from getDecodedIdToken and getAccessToken methods. (.changeset/giant-gifts-double.md)

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 72425d3 into asgardeo:main Jan 10, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants