Skip to content

fix: bug in lz4 decompression handling on multiple compression blocks #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
embray merged 2 commits into from
May 14, 2026
Merged

fix: bug in lz4 decompression handling on multiple compression blocks #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf46573
fix: bug in lz4 decompression handling on multiple compression blocks
embray May 14, 2026
b7aa76b
fix: follow-up to #192 -- this should be changed to `asdf_ndarray_data`
embray May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/compression/lz4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ static int asdf_compresser_lz4_read_block(asdf_compressor_lz4_userdata_t *lz4) {
}

lz4->pos += lz4->header.block_size;
lz4->header.pos = 0;
return 0;
}

Expand Down
2 changes: 1 addition & 1 deletion src/core/ndarray.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,7 +1606,7 @@ asdf_ndarray_err_t asdf_ndarray_read_tile_ndim(
size_t src_tile_size = src_elsize * tile_nelems;
size_t tile_size = dst_elsize * tile_nelems;
size_t data_size = 0;
const void *data = asdf_ndarray_data_raw(ndarray, &data_size);
const void *data = asdf_ndarray_data(ndarray, &data_size);

if (data_size < src_tile_size)
return ASDF_NDARRAY_ERR_OUT_OF_BOUNDS;
Expand Down
Loading