Fix submodule visibility in country modules#479
Closed
philmas wants to merge 1 commit intoarthurdejong:masterfrom
Closed
Fix submodule visibility in country modules#479philmas wants to merge 1 commit intoarthurdejong:masterfrom
philmas wants to merge 1 commit intoarthurdejong:masterfrom
Conversation
Add explicit imports to __init__.py files for all country modules to make
submodules visible via dir() function. This resolves the issue where
submodules like stdnum.gb.nhs, stdnum.us.ssn, etc. were not discoverable
through introspection despite being importable directly.
Changes:
- Added explicit 'from stdnum.{country} import {module}' statements
- Added '# noqa: F401' comments to suppress unused import warnings
- Ensures all submodules are now visible in dir() output
- Maintains backward compatibility for direct imports
Fixes module discoverability for all country-specific validation modules.
Owner
|
Hi @philmas, Thanks for your suggestion. I don't think I fully understand the use case behind the change. Introspection works fine with For example, to get all the UK number format modules, you can do: (by default it will list all the number formats) |
Owner
|
Closing this PR given that the functionality already seems to be available. Feel free to re-open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit imports to init.py files for all country modules to make submodules visible via dir() function. This resolves the issue where submodules like stdnum.gb.nhs, stdnum.us.ssn, etc. were not discoverable through introspection despite being importable directly.
Changes:
Fixes module discoverability for all country-specific validation modules.