Fix #471: Enforce correct format for GS1-128 trade measure AIs#472
Closed
zipus wants to merge 1 commit intoarthurdejong:masterfrom
Closed
Fix #471: Enforce correct format for GS1-128 trade measure AIs#472zipus wants to merge 1 commit intoarthurdejong:masterfrom
zipus wants to merge 1 commit intoarthurdejong:masterfrom
Conversation
…32nn, 35nn, 36nn)
zipus
force-pushed
the
fix-471-gs1_128-ai-validation
branch
from
5b0a67e to
4b86b5a
Compare
Owner
|
Closing this in favour of what was merged in 210b9ce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses Issue #471 regarding the incorrect parsing of trade measure Application Identifiers (AIs) in the
gs1_128module.🔍 Problem
The parser was accepting invalid 3-digit AIs such as (310), which are not defined in the GS1 General Specifications. According to the GS1 standard, only AIs in the format (31nn), (32nn), (35nn), and (36nn) are valid for trade measures. For example, (3103) indicates net weight in kilograms with 3 decimal places — (310) is not valid.
✅ Fix
📚 Reference
GS1 General Specifications – Release 25.0 (2025), Section 3.6.2 – page 166.
Please let me know if you'd like any adjustments or more test coverage.