-
Notifications
You must be signed in to change notification settings - Fork 16
ci: Add kind e2e test #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a463a9a to
cbd116e
Compare
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
cbd116e to
4bbced9
Compare
GeorgeJahad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
.github/workflows/integration.yml
Outdated
| @@ -0,0 +1,95 @@ | |||
| name: Integration | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is more of an e2e test than an integration one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed
.github/workflows/integration.yml
Outdated
| - name: Starting Armada cluster | ||
| run: make kind-all | ||
|
|
||
| - name: Create queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am more in favour of an approach where the test is defined in a bash script, as we can also execute it locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but all this boils down to:
./bin/app/armadactl create queue example
./bin/app/armadactl submit dev/quickstart/example-job.yaml
which is taken from the README.md.
The boilerplate code is hopefully only temporary until #321 is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think #321 will be fixed, as Armada is eventually consistent by design, and clients should handle retries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice if the armadactl would have an option to wait for the consistency, then users wouldn't need to implement that individually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worthwhile opening an Issue in the https://github.com/armadaproject/armada repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found scripts/e2e-test.sh, moving code there and invoking this from CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing scripts/e2e-test.sh does not work for me locally and on Github c04d991:
https://github.com/armadaproject/armada-operator/actions/runs/13973241267/job/39120298108?pr=355#step:4:608
Problem is that
make docker-build
produces a docker image that does not work:
$ docker run --rm -it gresearch/armada-operator:v0.5.0-8-g4da5900
exec /armada-operator: no such file or directory
@dejanzele any suggestions?
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
23d7c0f to
7c7abca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 81.37% 81.37%
=======================================
Files 16 16
Lines 3474 3474
=======================================
Hits 2827 2827
Misses 452 452
Partials 195 195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/workflows/e2e.yml
Outdated
| cache-prefix: go-integration-kind | ||
|
|
||
| - name: Starting Armada cluster | ||
| run: make kind-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make kind-all installs the latest released Armada Operator Helm chart - https://github.com/armadaproject/armada-operator/blob/main/Makefile#L214
This way we run e2e tests for the latest released Operator, and in case of a change to Operator code or Helm chart, the e2e test won't cover that scenario.
I think it might be better to create a make kind-all-local or edit the make kind-all-dev to build the code and install from the local Helm chart.
That way we would cover the scenario to do an e2e test on current Operator code and on current Helm chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this?
561dced#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R218
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
7ad4c52 to
561dced
Compare
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Description
This adds an integration test workflow to the CI running
make kind-alland submitting an example job..This should help to flag issues like #354 early.
Type of change
CI
How Has This Been Tested?
CI
Checklist: