Skip to content

Replace hardcoded value in precompileMorphs for tuple defaults#1574

Merged
ssalbdivad merged 2 commits intoarktypeio:mainfrom
shaungrady:fix-hardcoded-5
Mar 4, 2026
Merged

Replace hardcoded value in precompileMorphs for tuple defaults#1574
ssalbdivad merged 2 commits intoarktypeio:mainfrom
shaungrady:fix-hardcoded-5

Conversation

@shaungrady
Copy link
Copy Markdown
Contributor

@shaungrady shaungrady commented Dec 25, 2025

Replaces hardcoded value (5) in precompileMorphs for tuple defaults introduced in #1381.

First commit introduces a breaking test, second commit introduces the fix.

  • Code is up-to-date with the main branch
  • You've successfully run pnpm prChecks locally
  • There are new or updated unit tests validating the change

@shaungrady shaungrady force-pushed the fix-hardcoded-5 branch 2 times, most recently from 59e7cf9 to 98be9d6 Compare December 25, 2025 02:00
@shaungrady shaungrady marked this pull request as ready for review December 25, 2025 02:17
@ssalbdivad
Copy link
Copy Markdown
Member

Sorry for the delay merging this, thanks for the fix :shipit:

@ssalbdivad ssalbdivad merged commit 6758030 into arktypeio:main Mar 4, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from To do to Done (merged or closed) in arktypeio Mar 4, 2026
@shaungrady shaungrady deleted the fix-hardcoded-5 branch March 5, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done (merged or closed)

Development

Successfully merging this pull request may close these issues.

2 participants