feat(json-schema): Add custom definition ID#1467
Draft
PainOchoco wants to merge 4 commits intoarktypeio:mainfrom
Draft
feat(json-schema): Add custom definition ID#1467PainOchoco wants to merge 4 commits intoarktypeio:mainfrom
PainOchoco wants to merge 4 commits intoarktypeio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables users to add a custom JSON Schema definition ID, and makes possible what is described in the following issue: #1459
Please let me know if you need a unit test for this pretty simple addition? I'll also update the docs if you agree on this PR