Meta data #22
Open
Meta data #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpraglowski
reviewed
May 5, 2017
| def create_event(event_data) | ||
| type = event_data.event_type | ||
| data = event_data.data | ||
| meta_data = event_data.meta_data if event_data.respond_to?(:meta_data) |
Member
There was a problem hiding this comment.
why meta_data ? I would prefer metadata as this is just a single word
mpraglowski
reviewed
May 5, 2017
| private | ||
|
|
||
| def create_event(entry) | ||
| return nil unless entry['data'] |
Member
mpraglowski
reviewed
May 5, 2017
| describe '#append_to_stream' do | ||
|
|
||
| it "should handle one event" do | ||
| event = Event.new('event_type', { data: 1 }) |
Member
There was a problem hiding this comment.
You are adding new thing here - so why changing existing tests instead of just adding a new one ?
Contributor
Author
|
Thanks @mpraglowski for your time and comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to append meta_data to events.