Requiring type annotations in all top level functions#379
Merged
Conversation
Collaborator
rodrigogribeiro
commented
May 12, 2026
rodrigogribeiro
commented
- This PR makes all top level functions to require type annotations.
- Fixes all test cases to use type annotations.
- Fixes all test cases to use fully annotated top-level functions.
mbenke
approved these changes
May 13, 2026
Collaborator
mbenke
left a comment
mbenke
left a comment
There was a problem hiding this comment.
Looks good, one minor point.
I am afraid the merge conflicts with other PRs might be brutal though.
Comment on lines
+1212
to
+1224
| requireAnnotations :: FunDef Name -> TcM () | ||
| requireAnnotations (FunDef sig@(Signature _ _ _ ps rt) _) = | ||
| unless (all isTyped ps && isJust rt) $ | ||
| tcmError $ | ||
| unlines | ||
| [ "Top-level function must have complete type annotations:", | ||
| " " ++ pretty sig, | ||
| "Annotate every parameter (name : Type) and provide a return type (-> Type)." | ||
| ] | ||
| where | ||
| isTyped (Typed _ _) = True | ||
| isTyped _ = False | ||
|
|
Collaborator
There was a problem hiding this comment.
This partly duplicates the code in fullSignature above, perhaps a shared helper like this may alleviate this:
isFullyAnnotated :: FunDef Name -> Bool
isFullyAnnotated (FunDef (Signature _ _ _ ps rt) _) =
all isTyped ps && isJust rt
where
isTyped (Typed _ _) = True
isTyped _ = False
Collaborator
|
Also, the tests |
Collaborator
Author
I removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.