Fix ze library topo sort#503
Merged
Merged
Conversation
The DFS in gen_ze_library.rb returned early on CustomType nodes, so struct members and function-pointer params that referenced another typedef by name never pulled that typedef forward. The resulting ze_library.rb was loadable only by coincidence of $all_types order (which depends on the libclang version h2yaml uses). Now CustomType nodes resolve through a name->Decl map and recurse, and the case-branch also handles typedef-to-typedef Decls (e.g. `typedef uint8_t ze_bool_t`). Fuzz-tested with 130 random shuffles and a full-reverse of every list in ze_api.yaml; previously the same shuffles failed 10/10 with NameError/TypeError at FFI layout time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DFS in gen_ze_library.rb returned early on CustomType nodes, so struct members and function-pointer params that referenced another typedef by name never pulled that typedef forward. The resulting ze_library.rb was loadable only by coincidence of $all_types order (which depends on the libclang version h2yaml uses).
Now CustomType nodes resolve through a name->Decl map and recurse, and the case-branch also handles typedef-to-typedef Decls (e.g.
typedef uint8_t ze_bool_t). Fuzz-tested with 130 random shuffles and a full-reverse of every list in ze_api.yaml; previously the same shuffles failed 10/10 with NameError/TypeError at FFI layout time.