[CLI] Add a destroy app command #129
Open
+195
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucarin91
requested changes
Dec 4, 2025
Contributor
Author
Add uninitialized status and set status information for app list
|
lucarin91
reviewed
Dec 15, 2025
Contributor
lucarin91
left a comment
lucarin91
left a comment
There was a problem hiding this comment.
We should also add an endpoint for doing this (maybe in a subsequent PR)
internal/orchestrator/helpers.go
Outdated
| } | ||
|
|
||
| // TODO: merge this with the more efficient getAppStatusByPath | ||
| func getAppStatus( |
Contributor
There was a problem hiding this comment.
I would keep the TODO or add a FIXME, because I would like to remove this function and just use the getAppStatusByPath instead
Contributor
Author
There was a problem hiding this comment.
I removed the TODO because I implemented it
Contributor
There was a problem hiding this comment.
No, you don't, after your change we have two functions that do the same thing, the objective was to have just a single one.
Contributor
Author
There was a problem hiding this comment.
ah now I see what you mean, done by the following:
3 tasks
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #105
We could add a new app destroycommand (or a similar name) for stopping and removing all the data of an app.
In particular, we should do a docker-compose down and remove the .cache.
We should also consider adding a destroyed (or a better name) that is the default state of an app if it has not been run yet.
With this additional state, we would then be able to always return a state when listing the apps (right now apps and examples that have not been run, will show up as with no state).
Change description
Additional Notes
Reviewer checklist
main.