-
-
Notifications
You must be signed in to change notification settings - Fork 743
Unify SERCOM clock frequency handling across UART/SPI/WIRE #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use IRLibRecvPCI class from IRLib2 with Adafruit pIRKey, it's necessary to allow interrupts on this pin.
Enable Interrupt adafruit#8 on Pin PORTA28 (GPIO2)
…rduinoCore-samd into fix_compile_warnings3
This reverts commit 5cbfd74.
Improve build script & fix more warnings
Removing _dacResolution for __SAMD51__ is not defined (variable not used)
- make Tone_Handler() a strong symbol
Fix tone on SAMD51
add blm badge
Matrix portal draft
two more TRRS
without the suffix, the value is erroneously being shifted twice, which happens to be harmless in these particular instances because the shift is by zero
update to 3.1.5 of Adafruit TinyUSB
Add .ramfunc attribute to flash_with_bootloader.ld to enable keeping functions in RAM
Fix hangs when transfer errors occur
Adding analog support to the 3-pin JST A6.
…t-name fix variant folder name case for trrstrinkey_m0
add issue template
add missing _Val suffix on arguments to GCLK_GENCTRL_SRC()
fix tone with low frequency e.g 25 hz
Fix hang in noTone()
…nels same51g19a: Fix missing ETC channel definitions in WVariant
Revert a part of ccfc7db. It breaks I2C communcation.
Sercom: partially revert error handling change
|
Richard Campbell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Superseded by PR #381. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a series of bugs relating to:
GCLK->PCHCTRL[clk_id].reg = GCLK_PCHCTRL_GEN_GCLK1_Val | (1 << GCLK_PCHCTRL_CHEN_Pos)to values that exceeded Table 54-6 (see also Table 14-9) values forclk_id =3(FDPLL0 and FDPLL1 Reference clock frequency) by 3,750%. The code had originally missed in the datasheet where theCOREclock controls the SERCOM frequency, Section 36.5.3:The calculation of baudrates particularly
I2CM.BAUD.bit.BAUDandI2CM.BAUD.bit.HSBAUDthat were not in accordance Section 36.6.4.2.1.1 and 36.6.4.2.1.2 for the SAM D5x/E5x and Section 28.6.2.4.1.1 and 28.6.4.2.1.2 for the SAM D21/DA1 chips.It the clock of a SAM D5x/E5x was set during runtime from the default 48 MHz, there was a situation where the
BAUDsetting for UART and I2C was not set correctly and could have as much as 100% error between actual and desired bus baudrates.Not Addressed: There is an overflow condition in the calculation of
BAUDandHSBAUDsettings, recommend adding the following pseudo code to clamp I2C baudrates ininitMasterWire(baudtate). With low enoughbaudrateit is possible to generate an overflow condition where theBAUDwould be very low, e.g.0x01generating a baudrate that exceeds the maximum specified value.