Implement Wire.end() for SAM core #3730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also moved common reset and disable code in libsam TWI_ConfigureMaster and TWI_ConfigureSlave functions to new TWI_Disable function, which is used in TwoWire::end()
sandeepmistry
added
Library: Wire
Contributor
Author
|
@cmaglie I received a Due board to test with, unfortunately the patch doesn't work, the voltage on the pins were still high after |
…d board provided VID & PID. This is not always true, especially with counterfeits. Fixes arduino#3738
Like GUI mode does when a board is changed.
According to arduino#3634 I added the Ethernet.maintain to examples: Webserver UdpNtpClient DhcpChatServer DhcpAddressPrinter
like discussed in arduino#3537
was using only lower 8 bits of configuration registers
SerialPlotter now uses min/2 and max*2 instead of plain min and max Ticks works also when min == max Fixes arduino#3767
…n at its beginning. Fixes arduino#3513
…(for example) in sketchbook/hardware, but merge their contents. Fixes arduino#3851
…s missing/corrupted or if it the downloaded one if corrupted. Fixes arduino#3778
Timer is declared above, so nothing is missing here.
Contributor
Author
|
I'll open another pull request with my updated changes for this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the SAM side of #613.
Also moved common reset and disable code in libsam
TWI_ConfigureMasterand
TWI_ConfigureSlavefunctions to newTWI_Disablefunction, which isused in
TwoWire::end()@cmaglie needs to be run and verified on a Due board (both Wire master and slave), as I don't have one to test on yet.