Skip to content

Refactor auth_handler to use dependency injection #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Jan 27, 2026
+7 −5
Merged

Refactor auth_handler to use dependency injection #4171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions archinstall/lib/authentication/authentication_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,3 @@ def _configure_u2f_mapping(
existing_keys = all_keys

u2f_auth_file.write_text(existing_keys)


auth_handler = AuthenticationHandler()
9 changes: 7 additions & 2 deletions archinstall/scripts/guided.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from archinstall.lib.applications.application_handler import application_handler
from archinstall.lib.args import arch_config_handler
from archinstall.lib.authentication.authentication_handler import auth_handler
from archinstall.lib.authentication.authentication_handler import AuthenticationHandler
from archinstall.lib.configuration import ConfigurationOutput
from archinstall.lib.disk.filesystem import FilesystemHandler
from archinstall.lib.disk.utils import disk_layouts
Expand Down Expand Up @@ -54,6 +54,7 @@ def ask_user_questions(mirror_list_handler: MirrorListHandler) -> None:
def perform_installation(
mountpoint: Path,
mirror_list_handler: MirrorListHandler,
auth_handler: AuthenticationHandler,
) -> None:
"""
Performs the installation steps on a block device.
Expand Down Expand Up @@ -219,7 +220,11 @@ def guided() -> None:
fs_handler = FilesystemHandler(arch_config_handler.config.disk_config)
fs_handler.perform_filesystem_operations()

perform_installation(arch_config_handler.args.mountpoint, mirror_list_handler)
perform_installation(
arch_config_handler.args.mountpoint,
mirror_list_handler,
AuthenticationHandler(),
)


guided()