Conversation
arademaker
requested changes
Jun 16, 2022
Owner
arademaker
left a comment
arademaker
left a comment
There was a problem hiding this comment.
Please see my comments. I believe the changes do not address the changes in the Lattes Specification.
| <xsl:template match="TRABALHO-EM-EVENTOS"> | ||
| <mods:mods ID="publication-{@SEQUENCIA-PRODUCAO}"> | ||
| <mods:titleInfo> | ||
| <mods:title> <xsl:value-of select="DADOS-BASICOS-DO-TRABALHO/@TITULO-DO-TRABALHO" /> </mods:title> |
Owner
There was a problem hiding this comment.
Why did you change it? In my CV, the tag DADOS-BASICOS-DO-TRABALHO is the child of TRABALHOS-EM-EVENTOS. The XSD confirms that.
| </mods:titleInfo> | ||
|
|
||
| <mods:originInfo> | ||
| <mods:dateIssued> <xsl:value-of select="DADOS-BASICOS-DO-TRABALHO/@ANO-DO-TRABALHO" /> </mods:dateIssued> |
| <xsl:apply-templates select="DETALHAMENTO-DO-TRABALHO/@ISBN"/> | ||
| </mods:relatedItem> | ||
|
|
||
| <xsl:apply-templates select="DADOS-BASICOS-DO-TRABALHO/@IDIOMA"/> |
|
|
||
| <xsl:template match="@DOI"> | ||
| <xsl:if test="normalize-space(.) != ''"> | ||
| <mods:identifier type="doi"><xsl:value-of select="."/></mods:identifier> |
Owner
There was a problem hiding this comment.
Let us try to avoid changes that are meaningless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix my mass in last PR :)
Now just update one file