Skip to content

Conversation

@andrew
Copy link
Contributor

@andrew andrew commented Sep 22, 2024

Also testing against a range of currently supported ruby versions, plus 2.7 for backwards compatibility.

Testing against ruby 2.7 through to 3.3
@aquasync
Copy link
Owner

aquasync commented Oct 8, 2024

Hi @andrew, I don't have much familiarity with github actions (or travis ci for that matter!) - I didn't add the initial continuous integration, that was @taichi-ishitani. What's the point of this switch - is it just that github ci is more integrated/easier to use?

@taichi-ishitani
Copy link
Contributor

I switched my CI flow from travis to GitHub Actions 4 years ago because travis was very slow at that time.

@taichi-ishitani
Copy link
Contributor

How about using the bundler-cache: true option of the setup ruby action like this?
https://github.com/taichi-ishitani/rupkl/blob/177f38d94116ef9b263c93fdf7eed717fba7d898/.github/workflows/ci.yml#L30

Then depdended gems will be installed automatically and so we can remove following 2 actions.

- name: Install Bundler
run: gem install bundler
- name: Install dependencies
run: bundle install

@andrew
Copy link
Contributor Author

andrew commented Oct 9, 2024

I’m on holiday this week, can add it when I get back or feel free to edit the branch yourself, I think I made it writable to admins

@andrew
Copy link
Contributor Author

andrew commented Oct 28, 2024

@taichi-ishitani I've updated ci.yml now to use bundler-cache: true, I also added a Gemfile so that bundler correctly installs all the test dependencies.

@aquasync travis ci's free option for open source has got significantly worse over the past few years, github actions is nicely integrated into the standard github workflow, it's also fast, free and unrestrictred for open source projects.

I also noticed a few deprecation warnings in the logs but I'll open seperate PRs for those once this is merged.

@aquasync
Copy link
Owner

aquasync commented Nov 4, 2024

Ok thanks @andrew.

@aquasync aquasync merged commit a79a40d into aquasync:master Nov 4, 2024
@aquasync
Copy link
Owner

aquasync commented Nov 4, 2024

It doesn't seem to be running; looking at the config, is the issue that it mentions push/pr to "main" branch, whereas this repo has "master"?

@andrew
Copy link
Contributor Author

andrew commented Nov 4, 2024

It doesn't seem to be running; looking at the config, is the issue that it mentions push/pr to "main" branch, whereas this repo has "master"?

yep, sorry my mistake, updated here: #30

@aquasync
Copy link
Owner

aquasync commented Nov 4, 2024

Cool, yep that fixed it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants