-
Notifications
You must be signed in to change notification settings - Fork 24
Switch CI from travis-ci to GitHub actions #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Testing against ruby 2.7 through to 3.3
|
Hi @andrew, I don't have much familiarity with github actions (or travis ci for that matter!) - I didn't add the initial continuous integration, that was @taichi-ishitani. What's the point of this switch - is it just that github ci is more integrated/easier to use? |
|
I switched my CI flow from travis to GitHub Actions 4 years ago because travis was very slow at that time. |
|
How about using the Then depdended gems will be installed automatically and so we can remove following 2 actions. ruby-ole/.github/workflows/ci.yml Lines 32 to 36 in 322923b
|
|
I’m on holiday this week, can add it when I get back or feel free to edit the branch yourself, I think I made it writable to admins |
|
@taichi-ishitani I've updated ci.yml now to use @aquasync travis ci's free option for open source has got significantly worse over the past few years, github actions is nicely integrated into the standard github workflow, it's also fast, free and unrestrictred for open source projects. I also noticed a few deprecation warnings in the logs but I'll open seperate PRs for those once this is merged. |
|
Ok thanks @andrew. |
|
It doesn't seem to be running; looking at the config, is the issue that it mentions push/pr to "main" branch, whereas this repo has "master"? |
yep, sorry my mistake, updated here: #30 |
|
Cool, yep that fixed it - thanks! |
Also testing against a range of currently supported ruby versions, plus 2.7 for backwards compatibility.