Vhost settings #408
Draft
Vhost settings #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguilinger
reviewed
Jan 22, 2026
| settings[key.to_s.upcase] = value.to_s | ||
| end | ||
|
|
||
| # This one we pass through to nginx for whatever rason, so |
Member
There was a problem hiding this comment.
'rason'
also this seems like maybe something we should handle in the sweetness level? i.e. make sure we're only passing 'on' or 'off' based on reasonable values? (What if someone does direct api calls?)
not something you need to fix here, just noting
aguilinger
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low priority, we won't merge/release this until we have the corresponding Terraform provider changes ready, too. Leaving as draft, but ready for review while it's fresh.
The options should be self explanatory in the help. EG pass
--idle-timeout 123to set the IDLE_TIMEOUT for the Vhost. Less obvious behavior we'll need to add to the docs is how to unset and revert back to the platform default if you don't want to provide a value anymore: this can be accomplished with--idle-timeout=""or--idle-timeout defaultThor boolean option like
--force-ssland--no-force-sslseem to provide no way to to revert, though I suppose we could add custom options like--default-idle-timeoutand pass the value as a blank string to unset it in our API?A modicum of integration tests will be added here: https://github.com/aptible/aptible-integration/pull/565