Validate spec references with swagger parser#60
Conversation
Greptile SummaryThis PR fixes dangling Confidence Score: 5/5Safe to merge — only a P2 suggestion about pinning Node.js in CI; all spec fixes and the new validation script are correct. All findings are P2 (no P0 or P1). The spec removals are accurate, the script logic is correct, and the CI wiring works as described. .github/workflows/ci.yml — missing setup-node step Important Files Changed
Reviews (4): Last reviewed commit: "Validate spec references with swagger pa..." | Re-trigger Greptile |
8c6754c to
e29ac73
Compare
e29ac73 to
d32828c
Compare
d32828c to
07d3e9b
Compare
07d3e9b to
b7e2798
Compare
What changed
attributeVarchar,attributeText,attributeMediumtext,attributeLongtextcolumnVarchar,columnText,columnMediumtext,columnLongtext@apidevtools/swagger-parserand avalidate:refsscript that dereferences every spec file with schema/spec validation disabled, catching unresolved$refpointers without failing on unrelated historical schema-shape issues.metricschema to 0.12.x-0.14.x console Swagger/OpenAPI specs so the strict ref validator passes across the existing repository baseline.Why
Fixes #46. The 1.8.x specs referenced local schemas that do not exist. These string types were introduced in Appwrite 1.9.0, so 1.8.x should not advertise them in collection/table response unions.
The new parser validation catches the original broken 1.8.x spec with:
Missing $ref pointer "#/definitions/columnVarchar".Reference: https://github.com/appwrite/appwrite/releases/tag/1.9.0
Testing
npm ci --no-audit --no-fundnpm run validate:refs -- specsorigin/mainwith the missingcolumnVarcharref.