Skip to content

FIX GitHub action triggering for building image #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidjeddy wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −5
Open

FIX GitHub action triggering for building image #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1018eb
FIX GitHub action triggering for building image
davidjeddy Mar 13, 2026
1c81c7f
Feedback corrections
davidjeddy Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-and-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
docker image push ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-${{matrix.arch}}

manifest_build_and_push_on_feature:
if: github.ref != 'refs/heads/main'
if: github.ref != 'refs/heads/main' && !startsWith(github.ref, 'refs/tags/')
needs: build_and_push
runs-on: ubuntu-24.04
steps:
Expand All @@ -64,8 +64,8 @@ jobs:
run: |
docker manifest push ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}

manifest_build_and_push_on_main:
if: github.ref == 'refs/heads/main'
manifest_build_and_push_on_tag:
if: startsWith(github.ref, 'refs/tags/')
needs: build_and_push
runs-on: ubuntu-24.04
steps:
Expand Down
11 changes: 9 additions & 2 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# CHANGELOG

## Version 1.1.1

### Fix

* .github/workflows/build-and-push.yml manifest_build_and_push_on_feature no longer triggers on tag creation
* .github/workflows/build-and-push.yml manifest_build_and_push_on_tag now correctly builds on tag creation

## Version 1.1.0

### Add
Expand All @@ -26,13 +33,13 @@
* PHP version bumped to 8.5
* Refactored multi-arch build process to prevent cross-arch builds requiring long wait times

### Fixes
### Fix

* README.md usage instructions more detailed

### Miscellaneous

### Removed
### Remove

* Build tools from final stage of Dockerfile
* GitHub action to Setup QEMU as GitHub now provides native ARM runners
Loading