Skip to content

Chore remove promo#2956

Merged
HarshMN2345 merged 2 commits intomainfrom
chore-remove-promo
Apr 2, 2026
Merged

Chore remove promo#2956
HarshMN2345 merged 2 commits intomainfrom
chore-remove-promo

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@HarshMN2345 HarshMN2345 requested review from Meldiron and eldadfux April 2, 2026 12:17
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 2, 2026

Greptile Summary

This PR removes the "Imagine" promotional banner that was displayed as a bottom modal alert in the cloud console. It deletes the four files that made up the promo (imagine.svelte, imagine.svg, shader.svelte, noise.glsl) and strips the corresponding registration logic from bottomAlerts.ts, leaving addBottomModalAlerts as an empty stub that preserves the existing call-site in bottomModalAlert.svelte for future promos.

Key observations:

  • All deleted files are cleanly unreferenced after the change — no dangling imports were found.
  • The isSameDay import retained in bottomAlerts.ts is still actively used by the isPromoLive utility function, so there is no unused-import issue.
  • setMobileSingleAlertLayout (previously called for the Imagine promo's mobile layout) is no longer invoked, but its definition in $lib/stores/bottom-alerts.ts remains intact as general infrastructure — this is not a problem.
  • The empty addBottomModalAlerts stub is called on mount in bottomModalAlert.svelte; calling an empty function is harmless and keeps the pattern ready for the next promotion.

Confidence Score: 5/5

Safe to merge — pure deletion of unused promo assets with no functional regressions.

All changes are straightforward deletions of promotional code and assets. No stale references remain, imports are clean, and the call-site in bottomModalAlert.svelte continues to work correctly with the empty stub. No P0/P1 issues found.

No files require special attention.

Important Files Changed

Filename Overview
src/lib/components/promos/imagine.svelte Deleted — promo component using Threlte Canvas and the Imagine SVG logo, no longer needed.
src/lib/components/promos/imagine.svg Deleted — SVG asset for the Imagine promo banner, correctly removed alongside its consumer.
src/lib/components/promos/shader.svelte Deleted — Threlte/Three.js shader component driving the animated background of the Imagine promo.
src/lib/components/promos/threlte/shaders/noise.glsl Deleted — GLSL noise shader used by the Imagine promo shader component.
src/routes/(console)/bottomAlerts.ts Promo logic stripped; addBottomModalAlerts is now a no-op stub. The isSameDay import is still valid — used by the remaining isPromoLive utility. No stale references remain.

Reviews (1): Last reviewed commit: "remove shaders" | Re-trigger Greptile

@HarshMN2345 HarshMN2345 requested a review from ChiragAgg5k April 2, 2026 12:19
@HarshMN2345 HarshMN2345 merged commit eeea06d into main Apr 2, 2026
3 of 4 checks passed
@HarshMN2345 HarshMN2345 deleted the chore-remove-promo branch April 2, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants