Skip to content

fix: prevent TypeError when updating relationship attribute #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaydeep-pipaliya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent TypeError when updating relationship attribute #2953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...roject-[region]-[project]/databases/database-[database]/table-[table]/columns/edit.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@

export async function submit() {
try {
if (!option?.update) {
throw new Error('Unsupported column type');
}
await option.update(databaseId, tableId, selectedColumn, originalKey);
await invalidate(Dependencies.TABLE);

Expand Down Expand Up @@ -103,7 +106,7 @@

// TODO: @itznotabug - runes?
$: onShow(showEdit);
$: title = `Update ${columnOptions.find((v) => v.name === option.name)?.sentenceName ?? ''} column`;
$: title = `Update ${option ? (columnOptions.find((v) => v.name === option.name)?.sentenceName ?? '') : ''} column`;
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Redundant find when option is already the matched entry

When option is defined, it is already the result of columnOptions.find(...), so searching columnOptions a second time by option.name to get sentenceName is redundant — you can read option.sentenceName directly. This simplifies the expression and avoids a linear scan:

Suggested change
$: title = `Update ${option ? (columnOptions.find((v) => v.name === option.name)?.sentenceName ?? '') : ''} column`;
$: title = `Update ${option?.sentenceName ?? ''} column`;


function onShow(show: boolean) {
if (show) {
Expand Down