Verify drone-ssh binary checksum after download#410
Open
and9000 wants to merge 1 commit intoappleboy:masterfrom
Open
Verify drone-ssh binary checksum after download#410and9000 wants to merge 1 commit intoappleboy:masterfrom
and9000 wants to merge 1 commit intoappleboy:masterfrom
Conversation
Download checksums.txt from the drone-ssh release alongside the binary and verify it. Protects against tampered or corrupted release artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
entrypoint.shdownloads thedrone-sshbinary from GitHub releases over HTTPS but never verifies its integrity. If the release artifact is replaced or corrupted, the action silently executes the tampered binary — and since this action runs SSH commands with credentials against remote hosts, that's a meaningful supply-chain risk for every workflow consumingappleboy/ssh-action.Summary
checksums.txtfrom the drone-ssh release alongside the binary and verify it withshasum -c --ignore-missingbefore chmod'ing the binary executable.checksums.txtfetch on every invocation.