Support cancellation of tasks with FetchHTTPClient#157
Open
Conversation
The client now supports cancellation during `fetch()` API call and during reading of response body.
guoye-zhang
reviewed
May 8, 2026
| @JSClass(from: .global) struct AbortController: @unchecked Sendable { | ||
| @JSGetter var signal: JSObject? | ||
| @JSFunction init() throws(JSException) | ||
| @JSFunction func abort() throws(JSException) |
Collaborator
There was a problem hiding this comment.
Are these functions safe to call from any threads?
Collaborator
Author
There was a problem hiding this comment.
I'm no expert on how this translates to JS, but isn't JS single-threaded, making WASM single-threaded, making all the asynchronous contexts in Swift also single-threaded?
Collaborator
There was a problem hiding this comment.
I believe that multithreading is supported in WASM: https://webassembly.org/features/
Collaborator
Author
There was a problem hiding this comment.
Today I learned :) @MaxDesiatov might know more about this specific question...
guoye-zhang
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client now supports cancellation during
fetch()API call or during reading of the response body!The example app is now configured to cancel a request after 10 seconds to demonstrate this functionality.