Add trailer support to URLSession backend#122
Open
guoye-zhang wants to merge 3 commits intoapple:mainfrom
Open
Add trailer support to URLSession backend#122guoye-zhang wants to merge 3 commits intoapple:mainfrom
guoye-zhang wants to merge 3 commits intoapple:mainfrom
Conversation
guoye-zhang
requested review from
FranzBusch,
czechboy0,
fabianfett,
nakulbajaj,
travarin and
xbhatnag
guoye-zhang
commented
Feb 28, 2026
| body: (consuming sending URLSessionTaskDelegateBridge) async throws(Failure) -> Return | ||
| ) async throws(Failure) -> (Return, HTTPFields?) { | ||
| try await (body(self), nil) | ||
| try await (body(self), self.responseTrailerFields) |
Contributor
Author
There was a problem hiding this comment.
One of the reasons I think early returning before completing the read should throw is that we don't know whether nil means a trailer isn't present or it hasn't been received.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old stack supports sending trailers on h1/h3, and receiving trailers on all HTTP versions. The new stack only supports receiving trailers, so we still need to make that work.