Remove “import Cocoa” to make it work on iOS again#189
Open
ixeau wants to merge 1 commit intoapple:mainfrom
Open
Remove “import Cocoa” to make it work on iOS again#189ixeau wants to merge 1 commit intoapple:mainfrom
ixeau wants to merge 1 commit intoapple:mainfrom
Conversation
Cocoa is not available on iOS — therefore, the import prevents use of the package on iOS.
alejandro-isaza
approved these changes
Sep 21, 2024
alejandro-isaza
requested changes
Sep 21, 2024
Collaborator
alejandro-isaza
left a comment
alejandro-isaza
left a comment
There was a problem hiding this comment.
We would also need to remove the use of NSImage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cocoa is not available on iOS — therefore, the import prevents use of the package on iOS.