Fix Conv3d w8a8 quantization rank mismatch#2712
Open
tritolol wants to merge 2 commits into
Open
Conversation
Scale/zero-point expansion for conv weights only handled rank-4 (Conv2d). Generalize to rank >= 4 so Conv3d (rank-5) weights are also covered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
TobyRoseman
requested changes
May 22, 2026
|
|
||
|
|
||
| # region LinearQuantizer Conv3d | ||
| def test_linear_quantizer_conv3d_w8a8(): |
Collaborator
There was a problem hiding this comment.
This test fails even with your fix.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! The test was failing on macOS because verify_model_outputs hardcodes "input_1" as the predict input key ([conversion_utils.py:107]), but the forward parameter x caused CoreML to name the input "x_1" instead. Fixed by renaming the parameter to input_1 to match the convention used by the rest of the test suite.
verify_model_outputs hardcodes "input_1" as the predict key on macOS. Renaming the forward parameter to input_1 ensures CoreML names the model input consistently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code