Kwargs propagation from _get_model in quantize_weights to MLModel in _get_model#2244
Open
asafl wants to merge 1 commit intoapple:mainfrom
Open
Kwargs propagation from _get_model in quantize_weights to MLModel in _get_model#2244asafl wants to merge 1 commit intoapple:mainfrom
asafl wants to merge 1 commit intoapple:mainfrom
Conversation
…e, and in MLModel instantiation, to propagate weights_dir to MLModel.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
quantize_weightswith theweights_dirparameter, it doesn’t propagate toMLModel, resulting in:Exception: MLModel of type mlProgram cannot be loaded just from the model spec object. It also needs the path to the weights file. Please provide that as well, using the 'weights_dir' argument.Adding
**kwargsin line 1691, in_get_modelof thequantization_utilsmodule, in the_get_modelsignature and in the returnMLModel(spec, compute_units=compute_units, **kwargs)line fixes it.