docs: add more detail for PR expectations #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egernst
force-pushed
the
topic/contribution-doc
branch
from
75c7356 to
fffc440
Compare
Contributor
crosbymichael
left a comment
crosbymichael
left a comment
There was a problem hiding this comment.
Looks good, @katiewasnothere 's nit has nice wording.
egernst
force-pushed
the
topic/contribution-doc
branch
from
fffc440 to
1feffd2
Compare
crosbymichael
approved these changes
Jun 4, 2025
Contributor
|
You need a signed commit. |
Make sure we describe the project's merge strategy and expectations for pull requests. Signed-off-by: Eric Ernst <eric_ernst@apple.com>
egernst
force-pushed
the
topic/contribution-doc
branch
from
1feffd2 to
ed45e9d
Compare
katiewasnothere
pushed a commit
that referenced
this pull request
Jun 5, 2025
Make sure we describe the project's merge strategy and expectations for pull requests. Signed-off-by: Eric Ernst <eric_ernst@apple.com>
katiewasnothere
pushed a commit
that referenced
this pull request
Jun 5, 2025
Make sure we describe the project's merge strategy and expectations for pull requests. Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we describe the project's merge strategy and expectations for pull requests.