Fix TestCLIVersion build-type check for release CI#1627
Merged
Conversation
- Detected expected build via executable path (/debug/, /release/), but CI runs the CLI from bin/container — neither substring matched, so it fell back to 'debug' and mismatched the release binary. - Derive expected build from the test's own compile config (#if DEBUG), mirroring ReleaseVersion.buildType(); CLI and tests are always built with the same -c configuration.
zdk
changed the title
katiewasnothere
approved these changes
Jun 2, 2026
Code Coverage
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Refer to #1626
Fix by using the expected build from the test's compile config.
Testing
Tested Result:
