Skip to content

Support use of custom app root with system config in CLI commands#1600

Merged
katiewasnothere merged 1 commit into
apple:mainfrom
katiewasnothere:user/kbaldauf/ping_health_service_CLI
May 26, 2026
Merged

Support use of custom app root with system config in CLI commands#1600
katiewasnothere merged 1 commit into
apple:mainfrom
katiewasnothere:user/kbaldauf/ping_health_service_CLI

Conversation

@katiewasnothere
Copy link
Copy Markdown
Contributor

@katiewasnothere katiewasnothere commented May 26, 2026

Type of Change

  • Bug fix

Motivation and Context

Many CLI commands need to reference the system configurations for container. Previously, CLI commands would try to load the system configurations from the default application root location, regardless of if container had been started with a custom application root location. This PR fixes that issue by having each CLI command ping the APIServer's health check service to get the correct app root path.

Closes #1576

Testing

  • Tested locally

Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
@github-actions github-actions Bot added the cli label May 26, 2026
@github-actions
Copy link
Copy Markdown

Code Coverage

Tier Line Coverage
Unit 33.15%
Integration 19.65%
Combined 52.25%

@katiewasnothere katiewasnothere merged commit 25ab593 into apple:main May 26, 2026
4 checks passed
@katiewasnothere katiewasnothere deleted the user/kbaldauf/ping_health_service_CLI branch May 26, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Fix ContainerCommands to load config from the app root used by the API server.

2 participants