Skip to content

[images]: fix image load/save to use FilePathOps utility #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saehejkang wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[images]: fix image load/save to use FilePathOps utility #1590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4007d6
update image load/save to use FilePathOps
saehejkang May 22, 2026
38eb812
Merge branch 'main' into update-image-load-save-to-use-filepathops
saehejkang May 29, 2026
55d8b7c
Merge branch 'main' into update-image-load-save-to-use-filepathops
saehejkang Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Sources/ContainerCommands/Image/ImageLoad.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import ArgumentParser
import ContainerAPIClient
import Containerization
import ContainerizationError
import ContainerizationOS
import Foundation
import SystemPackage
import TerminalProgress
Expand All @@ -33,11 +34,7 @@ extension Application {
@Option(
name: .shortAndLong, help: "Path to the image tar archive", completion: .file(),
transform: { str in
let path = FilePath(str)
guard path.isRelative else { return path.lexicallyNormalized() }
return FilePath(FileManager.default.currentDirectoryPath)
.pushing(path)
.lexicallyNormalized()
FilePathOps.absolutePath(FilePath(str))
})
var input: FilePath?

Expand Down
7 changes: 2 additions & 5 deletions Sources/ContainerCommands/Image/ImageSave.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import ContainerResource
import Containerization
import ContainerizationError
import ContainerizationOCI
import ContainerizationOS
import Foundation
import SystemPackage
import TerminalProgress
Expand All @@ -48,11 +49,7 @@ extension Application {
@Option(
name: .shortAndLong, help: "Pathname for the saved image", completion: .file(),
transform: { str in
let path = FilePath(str)
guard path.isRelative else { return path.lexicallyNormalized() }
return FilePath(FileManager.default.currentDirectoryPath)
.pushing(path)
.lexicallyNormalized()
FilePathOps.absolutePath(FilePath(str))
})
var output: FilePath?

Expand Down