Skip to content

Conversation

Copy link

Copilot AI commented Nov 16, 2025

The RBS type signature files in sig/ were out of sync with the Ruby source files in lib/, with stale signatures for removed code and missing signatures for existing modules.

Changes

  • Removed sig/lib/appium_lib_core/android/device/network.rbs - Ruby file was deleted but RBS remained
  • Relocated sig/lib/appium_lib_core/ios/clipboard.rbssig/lib/appium_lib_core/ios/device/clipboard.rbs to match actual Ruby file path and removed obsolete method signatures
  • Added sig/lib/appium_lib_core/android/uiautomator2/device.rbs for existing module

All 66 RBS files now correspond 1:1 with Ruby source files containing module/class definitions. Files with only require statements correctly have no RBS counterparts.

Original prompt

This section details on the original issue you should resolve

<issue_title>Update RBS with the latest code</issue_title>
<issue_description>Update sig in https://github.com/appium/ruby_lib_core/tree/master/sig with the latest code basis such as #571.

Then, please add missing rbs files for the existing code in https://github.com/appium/ruby_lib_core/tree/master/lib</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 16, 2025

CLA Not Signed

- Remove sig/lib/appium_lib_core/android/device/network.rbs (no corresponding Ruby file)
- Move sig/lib/appium_lib_core/ios/clipboard.rbs to sig/lib/appium_lib_core/ios/device/clipboard.rbs
- Add sig/lib/appium_lib_core/android/uiautomator2/device.rbs

Co-authored-by: KazuCocoa <5511591+KazuCocoa@users.noreply.github.com>
Copilot AI changed the title [WIP] Update RBS with latest code and add missing files Sync RBS type signatures with current codebase Nov 16, 2025
Copilot AI requested a review from KazuCocoa November 16, 2025 17:34
@KazuCocoa KazuCocoa closed this Nov 16, 2025
@KazuCocoa KazuCocoa deleted the copilot/update-rbs-with-latest-code branch November 16, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update RBS with the latest code

2 participants