Skip to content

APT-2638: add observability for auth checks #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dannyeldridge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

APT-2638: add observability for auth checks #54

dannyeldridge wants to merge 1 commit into from

Conversation

@dannyeldridge
Copy link

@dannyeldridge dannyeldridge commented Dec 16, 2025 •
edited
Loading

This PR:

  • Adds AfObservability to Rails and Grape filter_access_filter methods
  • Adds span tags for controller/API, action, and result
  • Adds graceful fallback when AfObservability is not defined

@kermitapp
Copy link

kermitapp bot commented Dec 16, 2025

Jira Issue: https://appfolio.atlassian.net/browse/APT-2638

@dannyeldridge dannyeldridge force-pushed the APT-2638-authObservability branch from 3a2bd07 to 16f6274 Compare December 16, 2025 23:18
@dannyeldridge dannyeldridge changed the title feat: add observability for auth checks APT-2638: add observability for auth checks Dec 17, 2025
@dannyeldridge dannyeldridge marked this pull request as ready for review December 17, 2025 19:12
@dannyeldridge dannyeldridge requested a review from a team as a code owner December 17, 2025 19:12
jovan-appfolio
jovan-appfolio reviewed Dec 18, 2025
View reviewed changes
jovan-appfolio
jovan-appfolio reviewed Dec 20, 2025
View reviewed changes
jovan-appfolio
jovan-appfolio approved these changes Dec 20, 2025
View reviewed changes
Copy link
Contributor

@jovan-appfolio jovan-appfolio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would suggest getting maybe 1-2 more reviewers

jovan-appfolio
jovan-appfolio reviewed Dec 21, 2025
View reviewed changes
@dannyeldridge dannyeldridge force-pushed the APT-2638-authObservability branch from 8f0e6f6 to f5eebe3 Compare December 22, 2025 17:24
@mike-mike-mike-mike-mike
Copy link
Contributor

mike-mike-mike-mike-mike commented Dec 22, 2025 •
edited
Loading

I saw this AC: "On authorization errors, log an afexception. This may need to be configured via a callback config like the authorization denied callback"

Does that still need to be implemented? ignore, I see in the property PR

andrewdt23
andrewdt23 reviewed Dec 22, 2025
View reviewed changes
@dannyeldridge dannyeldridge force-pushed the APT-2638-authObservability branch 2 times, most recently from efef0bc to cb45b75 Compare December 23, 2025 23:04
@dannyeldridge dannyeldridge force-pushed the APT-2638-authObservability branch from cb45b75 to 1d1a09c Compare December 23, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewdt23 andrewdt23 andrewdt23 approved these changes

@jovan-appfolio jovan-appfolio jovan-appfolio approved these changes

@MicahRaney MicahRaney Awaiting requested review from MicahRaney

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dannyeldridge @mike-mike-mike-mike-mike @andrewdt23 @jovan-appfolio