[APT-2621] Delegate helper methods to controller #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than defining them separately. Since the helper methods don't do anything different than the controller methods (method signature is also unchanged), they can just be forwarded. This will also help with the effort to include hiearchy be default since the keyword argument doesn't need to be passed manually (causing an expectation error in tests).
|
Jira Issue: https://appfolio.atlassian.net/browse/APT-2621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helper methods essentially just delegate to the controller, but in a less reliable way than actually using
delegate(maybe that didn't exist when this was written).This PR updates that module to use
delegateto simplify the module, and tests that rely upon stubbing the controller methods. This will help with the effort to include hiearchy be default since the keyword argument doesn't need to be forwarded manually with a default (causing an expectation error in tests).