Skip to content

Fix/ADFA 609 feedback email #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jatezzz merged 7 commits into from
May 12, 2025
Merged

Fix/ADFA 609 feedback email #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1deb78
fix: Move email constant to strings.xml
jatezzz May 8, 2025
e4fdd7f
fix: Remove unused constant import
jatezzz May 8, 2025
d98fa03
lint
May 8, 2025
3be7b8e
Merge remote-tracking branch 'origin/stage' into fix/adfa-609
May 8, 2025
39845a0
lint
May 8, 2025
75eab3b
fix: Correct feedback email address
jatezzz May 9, 2025
96faef1
Merge remote-tracking branch 'origin/fix/adfa-609' into fix/adfa-609
jatezzz May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/assets/CoGoTooltips
Open in desktop
Submodule CoGoTooltips updated from 0bdf96 to c8beb9
10 changes: 5 additions & 5 deletions app/src/main/java/com/itsaky/androidide/fragments/MainFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import androidx.activity.result.contract.ActivityResultContracts
import androidx.appcompat.app.AlertDialog
import androidx.core.text.HtmlCompat
import androidx.fragment.app.viewModels
import org.adfa.constants.FEEDBACK_EMAIL
import com.google.android.material.progressindicator.LinearProgressIndicator
import com.itsaky.androidide.BuildConfig
import com.itsaky.androidide.R
import com.itsaky.androidide.activities.MainActivity
import com.itsaky.androidide.activities.PreferencesActivity
Expand All @@ -24,6 +24,7 @@ import com.itsaky.androidide.app.BaseIDEActivity
import com.itsaky.androidide.common.databinding.LayoutDialogProgressBinding
import com.itsaky.androidide.databinding.FragmentMainBinding
import com.itsaky.androidide.idetooltips.IDETooltipDatabase
import com.itsaky.androidide.idetooltips.IDETooltipItem
import com.itsaky.androidide.models.MainScreenAction
import com.itsaky.androidide.preferences.databinding.LayoutDialogTextInputBinding
import com.itsaky.androidide.preferences.internal.GITHUB_PAT
Expand All @@ -48,8 +49,6 @@ import org.slf4j.LoggerFactory
import java.io.File
import java.text.MessageFormat
import java.util.concurrent.CancellationException
import com.itsaky.androidide.BuildConfig
import com.itsaky.androidide.idetooltips.IDETooltipItem

class MainFragment : BaseFragment() {

Expand Down Expand Up @@ -168,7 +167,8 @@ class MainFragment : BaseFragment() {
.setNegativeButton(android.R.string.cancel) { dialog, _ -> dialog.dismiss() }
.setPositiveButton(android.R.string.ok) { dialog, _ ->
run {
val stackTrace = Exception().stackTrace.asList().toString().replace(",", "\n")
val stackTrace =
Exception().stackTrace.asList().toString().replace(",", "\n")

val feedbackMessage = getString(
R.string.feedback_message,
Expand All @@ -186,7 +186,7 @@ class MainFragment : BaseFragment() {
feedbackIntent.type = "text/plain"
feedbackIntent.putExtra(
Intent.EXTRA_EMAIL,
arrayOf(FEEDBACK_EMAIL)
arrayOf(R.string.feeback_email)
)
feedbackIntent.putExtra(Intent.EXTRA_SUBJECT, subject)
feedbackIntent.putExtra(Intent.EXTRA_TEXT, feedbackMessage)
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,5 @@ Connected to the target VM, address: \'localhost:46423\', transport: \'socket\'
<string name="more_label">More</string>
<string name="send_email">Send Email</string>
<string name="close">Close</string>
<string name="feeback_email">feedback@appdevforall.org</string>
</resources>
4 changes: 0 additions & 4 deletions composite-builds/build-deps-common/constants/src/main/java/org/adfa/constants/constants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,6 @@ const val CONTENT_KEY = "CONTENT_KEY"
// Toml
const val TOML_FILE_NAME = "libs.versions.toml"

//Email constant
const val FEEDBACK_EMAIL = "feedback@appdevforall.com"


// Help
const val HELP_PAGE_URL =
"file:///android_asset/CoGoTooltips/html/cogohelp/index.html"
Loading